Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix win_reg_stat for HKU hives #59359

Merged
merged 1 commit into from Jul 21, 2019
Merged

Fix win_reg_stat for HKU hives #59359

merged 1 commit into from Jul 21, 2019

Conversation

jborean93
Copy link
Contributor

SUMMARY

An unfortunately typo in win_reg_stat has stopped it working for any registry path in HKU:\. This PR fixes this typo and adds a test to help make sure this issue won't pop up again.

Fixes #59337

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

win_reg_stat

@jborean93 jborean93 mentioned this pull request Jul 21, 2019
Closed
@ansibot
Copy link
Contributor

ansibot commented Jul 21, 2019

cc @ShachafGoldstein @if-meaton @jhawkesworth @nitzmahone
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community labels Jul 21, 2019
@jborean93 jborean93 merged commit 2f2b106 into ansible:devel Jul 21, 2019
@jborean93 jborean93 deleted the win_reg_stat-hku branch July 21, 2019 23:12
jborean93 added a commit to jborean93/ansible that referenced this pull request Jul 21, 2019
@jborean93
Fix win_reg_stat for HKU hives (ansible#59359)
e3a9fe6 
(cherry picked from commit 2f2b106)
@jborean93 jborean93 mentioned this pull request Jul 21, 2019
Merged
@jborean93
Copy link
Contributor Author

Backport PR to stable-2.8 #59360.

@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Jul 22, 2019
abadger pushed a commit that referenced this pull request Jul 22, 2019
@jborean93 @abadger
Fix win_reg_stat for HKU hives (#59359)
e5f68ca 
(cherry picked from commit 2f2b106)
@ansible ansible locked and limited conversation to collaborators Aug 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

win_reg_stat fails when registry key is in HKEY_USERS\.DEFAULT hive
3 participants
@jborean93 @ansibot @sivel